Subo mi proyecto final, no se si falta algo o no pero seguí las especificaciones que nos distes. Si faltase algo estaré encantado de añadirlo y/o modificarlo.
@marioterron157 It's very good. From your code I assume that you already had a good base, and I see that you have introduced an icon font with Icomoon. The only thing that would change is that the navigation on the small screen works (you don't have to add the JavaScript if you don't want to, but something happens when we click on the icon), and maybe I would have introduced some more media query (you only have from 921px ) to correct small details, such as the composition just below 1024px of the "FRESH BREAD" blocks and so on.
In any case, congratulations on the project!
[EDITADO]One more thing: it wouldn't lock zoom on mobile, which is what this meta does:
<meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
Instead, you would simply put:
<meta name=viewport content="initial-scale=1.0, width=device-width">
4 comments
htmlboy
Teacher Plus@marioterron157 It's very good. From your code I assume that you already had a good base, and I see that you have introduced an icon font with Icomoon. The only thing that would change is that the navigation on the small screen works (you don't have to add the JavaScript if you don't want to, but something happens when we click on the icon), and maybe I would have introduced some more media query (you only have from 921px ) to correct small details, such as the composition just below 1024px of the "FRESH BREAD" blocks and so on.
In any case, congratulations on the project!
[EDITADO]One more thing: it wouldn't lock zoom on mobile, which is what this meta does:
<meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
Instead, you would simply put:
<meta name=viewport content="initial-scale=1.0, width=device-width">
See original
Hide original
marioterron157
@htmlboy Thank you very much! I will correct the viewport and media queries and add the small screen navigation and upload it again.
See original
Hide original
marioterron157
@htmlboy Added navigation.
See original
Hide original
htmlboy
Teacher Plus@marioterron157 nothing more to add, good job! I hope you liked the course :-)
See original
Hide original
Log in or join for Free to comment